Awesome, looks good to me. I don't know the x64 code too well though so I'll
leave it to someone else to lg.

https://codereview.chromium.org/419803009/diff/1/src/x64/macro-assembler-x64.cc
File src/x64/macro-assembler-x64.cc (right):

https://codereview.chromium.org/419803009/diff/1/src/x64/macro-assembler-x64.cc#newcode2958
src/x64/macro-assembler-x64.cc:2958: // TODO(bmeurer): r12 is
kSmiConstantRegister.
nit - r12 is currently unused (will be kConstantPoolPointer)

https://codereview.chromium.org/419803009/

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to