On 2014/08/01 14:46:57, rmcilroy wrote:
Awesome, looks good to me. I don't know the x64 code too well though so
I'll
leave it to someone else to lg.
https://codereview.chromium.org/419803009/diff/1/src/x64/macro-assembler-x64.cc
File src/x64/macro-assembler-x64.cc (right):
https://codereview.chromium.org/419803009/diff/1/src/x64/macro-assembler-x64.cc#newcode2958
src/x64/macro-assembler-x64.cc:2958: // TODO(bmeurer): r12 is
kSmiConstantRegister.
nit - r12 is currently unused (will be kConstantPoolPointer)
I think we decided not to do this until we're exactly sure what we're going
to
do with the constant pool in TurboFan. In principle we could free up R12 to
be
allocatable, but then we might have to take back again. So probably best to
leave it this way.
https://codereview.chromium.org/419803009/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
