Thanks for the review. As already discussed, the thennable bug will be fixed
separately from this CL.


https://codereview.chromium.org/440773004/diff/1/src/debug.cc
File src/debug.cc (right):

https://codereview.chromium.org/440773004/diff/1/src/debug.cc#newcode2586
src/debug.cc:2586: bool hasreject =
PromiseHasRejectHandler(Handle<JSObject>::cast(promise));
On 2014/08/05 11:59:39, aandrey wrote:
hasreject -> has_reject

Removed this interim result entirely.

https://codereview.chromium.org/440773004/diff/1/test/mjsunit/es6/debug-promises/reject-uncaught-all.js
File test/mjsunit/es6/debug-promises/reject-uncaught-all.js (right):

https://codereview.chromium.org/440773004/diff/1/test/mjsunit/es6/debug-promises/reject-uncaught-all.js#newcode28
test/mjsunit/es6/debug-promises/reject-uncaught-all.js:28: if (event ==
Debug.DebugEvent.AsyncTaskEvent) return;
On 2014/08/05 11:59:39, aandrey wrote:
can be dropped

Done.

https://codereview.chromium.org/440773004/

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to