LGTM with nits
https://codereview.chromium.org/440773004/diff/1/src/promise.js
File src/promise.js (right):
https://codereview.chromium.org/440773004/diff/1/src/promise.js#newcode35
src/promise.js:35: var PromiseHasRejectHandler;
Nit: move this up to the other Promise* vars.
Though, in fact, better remove all those vars and turn the assignments
below into var statements.
https://codereview.chromium.org/440773004/diff/1/src/promise.js#newcode327
src/promise.js:327: var queue = GET_PRIVATE(this, promiseOnReject);
Nit: move this line down by 2.
https://codereview.chromium.org/440773004/diff/1/src/promise.js#newcode330
src/promise.js:330: // If already rejected/resolved, the handlers have
already been fired.
If the status isn't 0 then the queue should be undefined anyway, so this
extra check shouldn't be needed.
https://codereview.chromium.org/440773004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
