On 2014/08/06 14:21:30, rossberg wrote:
https://codereview.chromium.org/443843004/diff/1/src/mirror-debugger.js
File src/mirror-debugger.js (right):
https://codereview.chromium.org/443843004/diff/1/src/mirror-debugger.js#newcode762
src/mirror-debugger.js:762: names[index++] = %ToString(elementNames[i]);
Hm, I don't understand why this change is necessary.
The documentation for PropertyMirror claims that name is a string (which I
generalized to Name in this patch). There is also the helper method
isIndexed.
%DebugGetPropertyDetails bails if the passed property is not a name. All of
these lead me to believe that at one point the design was that "name"
should be
a name and not a number. I am ignorant, though, about the direction that
this
code is moving.
https://codereview.chromium.org/443843004/diff/1/src/mirror-debugger.js#newcode800
src/mirror-debugger.js:800: name = IS_SYMBOL(name) ?
name : %ToString(name);
You can use %ToName for this.
Neat, will fix.
https://codereview.chromium.org/443843004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
