On 2014/08/07 08:26:57, wingo wrote:
On 2014/08/06 15:54:34, rossberg wrote:
> LGTM, modulo the comment
>
>
https://codereview.chromium.org/443843004/diff/20001/test/mjsunit/mirror-object.js
> File test/mjsunit/mirror-object.js (right):
>
>
https://codereview.chromium.org/443843004/diff/20001/test/mjsunit/mirror-object.js#newcode116
> test/mjsunit/mirror-object.js:116: // Serialization of symbol-named
properties
> to JSON doesn't really
> This isn't ever supposed to work; symbol properties are intentionally
ignored
by
> JSON, like anything else it cannot represent.
Not sure what you mean here. The symbol properties do get serialized to
JSON;
the JSON entry simply has no name property (!) so you can't know which
unnamed
property corresponds to which symbol. In this way you can see that an
object
has a symbol-valued property, and inspect the value, you just can't know
what
symbol it is. So, the comment does not seem to me to be misleading.
Okay, I wasn't aware that our JSON implementation does s.th weird with
symbol
properties. It should really just ignore them. I'll look into that.
https://codereview.chromium.org/443843004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
