https://codereview.chromium.org/425003004/diff/60001/src/compiler/node-properties.h
File src/compiler/node-properties.h (left):
https://codereview.chromium.org/425003004/diff/60001/src/compiler/node-properties.h#oldcode43
src/compiler/node-properties.h:43: private:
Wait, why?
https://codereview.chromium.org/425003004/diff/60001/src/compiler/node-sketch.cc
File src/compiler/node-sketch.cc (right):
https://codereview.chromium.org/425003004/diff/60001/src/compiler/node-sketch.cc#newcode41
src/compiler/node-sketch.cc:41: Output* target() { return target_; }
Isn't this rather a source than a target? The data is flowing from that
output to this input.
https://codereview.chromium.org/425003004/diff/60001/src/compiler/node-sketch.cc#newcode45
src/compiler/node-sketch.cc:45: if (out == target_) return; //
Redundant.
Hm, when would you willingly connect the same edge twice?
https://codereview.chromium.org/425003004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
