https://codereview.chromium.org/425003004/diff/20001/src/compiler/simplified-lowering.cc
File src/compiler/simplified-lowering.cc (right):
https://codereview.chromium.org/425003004/diff/20001/src/compiler/simplified-lowering.cc#newcode32
src/compiler/simplified-lowering.cc:32: enum Phase {
On 2014/08/06 13:04:07, rossberg wrote:
I wish we could somehow factor this using some form of
parameterisation, and not
a mode flag... :(
As discussed, the virtual method thing is going to result in pulling out
major portions into their own methods...
https://codereview.chromium.org/425003004/diff/20001/src/compiler/simplified-lowering.cc#newcode60
src/compiler/simplified-lowering.cc:60: RepTypeUnion output : 16; //
Output type of the node.
On 2014/08/06 13:04:07, rossberg wrote:
Why is this bitset larger than the other?
Done.
https://codereview.chromium.org/425003004/diff/20001/src/compiler/simplified-lowering.cc#newcode343
src/compiler/simplified-lowering.cc:343:
//------------------------------------------------------------------
On 2014/08/06 13:04:07, rossberg wrote:
Nit: weird indentation
clang-format keeps putting it back, so I'll just leave it.
https://codereview.chromium.org/425003004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
