Chrome will call this with an ever-increasing backoff. But, to prevent the battery killing, we could have the idlenotification function return true/false based on whether we should keep calling it. I will make that change.
Mike On Sun, Aug 23, 2009 at 2:35 PM, <[email protected]> wrote: > > http://codereview.chromium.org/174302/diff/5/1006 > File src/heap.h (right): > > http://codereview.chromium.org/174302/diff/5/1006#newcode843 > Line 843: // called repeatedly without JS activity, it will > It looks like this sentence hasn't been > > http://codereview.chromium.org/174302/diff/5/1006#newcode857 > Line 857: CollectAllGarbage(); > If the idle notification keep coming, will this do lots of garbage > collections? We need some way to determine whether any non-trivial work > has taken place since the last time we did an idle-loop garbage > collection. Otherwise V8 will be a battery-killer on laptops. > > > http://codereview.chromium.org/174302 > --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
