On 2009/08/23 21:35:34, Erik Corry wrote: > http://codereview.chromium.org/174302/diff/5/1006 > File src/heap.h (right):
> http://codereview.chromium.org/174302/diff/5/1006#newcode843 > Line 843: // called repeatedly without JS activity, it will > It looks like this sentence hasn't been fixed :-) > http://codereview.chromium.org/174302/diff/5/1006#newcode857 > Line 857: CollectAllGarbage(); > If the idle notification keep coming, will this do lots of garbage collections? > We need some way to determine whether any non-trivial work has taken place since > the last time we did an idle-loop garbage collection. Otherwise V8 will be a > battery-killer on laptops. Updated the API to return a bool after compaction; I've modified the browser side to detect that and stop calling (until the tab goes un-idle first). http://codereview.chromium.org/174302 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
