lgtm modulo 2 comments - great that this code is no longer needed! :)
1) Will this affect tests ran by WebKit? (So that you'd need to update test
expectations on the WebKit side before V8 can roll into Chromium.)
2) below
https://codereview.chromium.org/459463002/diff/40001/test/preparser/duplicate-property.pyt
File test/preparser/duplicate-property.pyt (left):
https://codereview.chromium.org/459463002/diff/40001/test/preparser/duplicate-property.pyt#oldcode134
test/preparser/duplicate-property.pyt:134:
It's kinda surprising that this test apparently tests number to string
conversions too! Do we have enough confidence that these cases are
covered by other tests, or should you add the number-to-string
conversion test cases somewhere separately?
https://codereview.chromium.org/459463002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
