Thanks for the review

I'll run the blink layout tests and disable/update the tests on the blink side
if needed.




https://codereview.chromium.org/459463002/diff/40001/test/preparser/duplicate-property.pyt
File test/preparser/duplicate-property.pyt (left):

https://codereview.chromium.org/459463002/diff/40001/test/preparser/duplicate-property.pyt#oldcode134
test/preparser/duplicate-property.pyt:134:
On 2014/08/12 07:47:44, marja wrote:
It's kinda surprising that this test apparently tests number to string
conversions too! Do we have enough confidence that these cases are
covered by
other tests, or should you add the number-to-string conversion test
cases
somewhere separately?

I can't find anything that covers this. I'll move these into an mjsunit
test in the form of.

assertSame(0x20, 32, "hex-int")

https://codereview.chromium.org/459463002/

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to