https://codereview.chromium.org/475423003/diff/1/src/runtime.cc
File src/runtime.cc (right):
https://codereview.chromium.org/475423003/diff/1/src/runtime.cc#newcode2070
src/runtime.cc:2070: return isolate->heap()->home_object_symbol();
Why do you need this?
https://codereview.chromium.org/475423003/diff/20001/src/harmony-classes.js
File src/harmony-classes.js (right):
https://codereview.chromium.org/475423003/diff/20001/src/harmony-classes.js#newcode15
src/harmony-classes.js:15: [%ToString(this), typeof this]);
Maybe TO_STRING_INLINE?
https://codereview.chromium.org/475423003/diff/20001/src/harmony-classes.js#newcode19
src/harmony-classes.js:19: if (!IS_SPEC_OBJECT(homeObject)) {
This is wrong order. This test should come before the is function test.
https://codereview.chromium.org/475423003/diff/20001/src/harmony-classes.js#newcode20
src/harmony-classes.js:20: throw MakeTypeError('toMethod_non_object');
Maybe include homeObject in the error message?
https://codereview.chromium.org/475423003/diff/20001/src/harmony-classes.js#newcode29
src/harmony-classes.js:29: "toMethod", FunctionToMethod
wrong indentation
https://codereview.chromium.org/475423003/diff/20001/test/mjsunit/harmony/toMethod.js
File test/mjsunit/harmony/toMethod.js (right):
https://codereview.chromium.org/475423003/diff/20001/test/mjsunit/harmony/toMethod.js#newcode31
test/mjsunit/harmony/toMethod.js:31: (function () {
Please name these. Makes it easier to know what you are testing
(function TestSomething() {
...
})();
https://codereview.chromium.org/475423003/diff/20001/test/mjsunit/harmony/toMethod.js#newcode64
test/mjsunit/harmony/toMethod.js:64:
two new lines between top level functions
https://codereview.chromium.org/475423003/diff/20001/test/mjsunit/harmony/toMethod.js#newcode80
test/mjsunit/harmony/toMethod.js:80: assertEquals(o,
fMeth[%HomeObjectSymbol()]);
Maybe define the private symbol in harmony-classes.js. That way there is
no need for the runtime function.
https://codereview.chromium.org/475423003/diff/20001/test/mjsunit/harmony/toMethod.js#newcode104
test/mjsunit/harmony/toMethod.js:104: }());
Can you add a test that we check the type of the newHome in toMethod
before we test the type of this.
https://codereview.chromium.org/475423003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
