An implementation of JSFunction::Copy + more tests.
https://codereview.chromium.org/475423003/diff/60001/src/runtime.cc
File src/runtime.cc (right):
https://codereview.chromium.org/475423003/diff/60001/src/runtime.cc#newcode2063
src/runtime.cc:2063: Object::SetProperty(clone, home_object_symbol,
home_object, STRICT));
On 2014/08/18 14:15:35, Toon Verwaest wrote:
Perhaps use JSObject::SetOwnPropertyIgnoreAttributes?
Done.
https://codereview.chromium.org/475423003/diff/60001/test/mjsunit/harmony/toMethod.js
File test/mjsunit/harmony/toMethod.js (right):
https://codereview.chromium.org/475423003/diff/60001/test/mjsunit/harmony/toMethod.js#newcode97
test/mjsunit/harmony/toMethod.js:97: function f(x, y, z) {
On 2014/08/18 14:15:35, Toon Verwaest wrote:
Add flag "called = false" on the outside, and set it to true on the
inside, to
ensure the method is even called.
Checking return value instead.
https://codereview.chromium.org/475423003/diff/60001/test/mjsunit/harmony/toMethod.js#newcode108
test/mjsunit/harmony/toMethod.js:108: }());
On 2014/08/18 14:15:35, Toon Verwaest wrote:
What about tests for rebinding a method, given that those are just
JSFunctions
too? (This is API is a bit weird imho...)
Done.
https://codereview.chromium.org/475423003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
