Revision: 23180
Author: [email protected]
Date: Tue Aug 19 08:14:01 2014 UTC
Log: Revert "Get rid of dead version of GetNormalizedProperty"
(Doh, landed too early)
[email protected]
BUG=
Review URL: https://codereview.chromium.org/487163002
http://code.google.com/p/v8/source/detail?r=23180
Modified:
/branches/bleeding_edge/src/objects.cc
/branches/bleeding_edge/src/objects.h
=======================================
--- /branches/bleeding_edge/src/objects.cc Tue Aug 19 07:09:41 2014 UTC
+++ /branches/bleeding_edge/src/objects.cc Tue Aug 19 08:14:01 2014 UTC
@@ -628,6 +628,22 @@
DCHECK(!value->IsPropertyCell() && !value->IsCell());
return value;
}
+
+
+Handle<Object> JSObject::GetNormalizedProperty(Handle<JSObject> object,
+ const LookupResult* result)
{
+ DCHECK(!object->HasFastProperties());
+ Isolate* isolate = object->GetIsolate();
+ Handle<Object> value(
+ object->property_dictionary()->ValueAt(result->GetDictionaryEntry()),
+ isolate);
+ if (object->IsGlobalObject()) {
+ value = handle(Handle<PropertyCell>::cast(value)->value(), isolate);
+ DCHECK(!value->IsTheHole());
+ }
+ DCHECK(!value->IsPropertyCell() && !value->IsCell());
+ return value;
+}
void JSObject::SetNormalizedProperty(Handle<JSObject> object,
=======================================
--- /branches/bleeding_edge/src/objects.h Tue Aug 19 07:09:41 2014 UTC
+++ /branches/bleeding_edge/src/objects.h Tue Aug 19 08:14:01 2014 UTC
@@ -2157,6 +2157,8 @@
// Retrieve a value in a normalized object given a lookup result.
// Handles the special representation of JS global objects.
Object* GetNormalizedProperty(const LookupResult* result);
+ static Handle<Object> GetNormalizedProperty(Handle<JSObject> object,
+ const LookupResult* result);
// Sets the property value in a normalized object given (key, value,
details).
// Handles the special representation of JS global objects.
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
