Reviewers: Jakob,
Message:
Committed patchset #1 manually as 23180 (tree was closed).
Description:
Revert "Get rid of dead version of GetNormalizedProperty"
(Doh, landed too early)
[email protected]
BUG=
Committed: https://code.google.com/p/v8/source/detail?r=23180
Please review this at https://codereview.chromium.org/487163002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+18, -0 lines):
M src/objects.h
M src/objects.cc
Index: src/objects.cc
diff --git a/src/objects.cc b/src/objects.cc
index
f5424800db77e56e1acd425036c2889d2d9664fe..52f858f17a5c88e05569b13ef384a8b4be252211
100644
--- a/src/objects.cc
+++ b/src/objects.cc
@@ -630,6 +630,22 @@ Object* JSObject::GetNormalizedProperty(const
LookupResult* result) {
}
+Handle<Object> JSObject::GetNormalizedProperty(Handle<JSObject> object,
+ const LookupResult* result)
{
+ DCHECK(!object->HasFastProperties());
+ Isolate* isolate = object->GetIsolate();
+ Handle<Object> value(
+ object->property_dictionary()->ValueAt(result->GetDictionaryEntry()),
+ isolate);
+ if (object->IsGlobalObject()) {
+ value = handle(Handle<PropertyCell>::cast(value)->value(), isolate);
+ DCHECK(!value->IsTheHole());
+ }
+ DCHECK(!value->IsPropertyCell() && !value->IsCell());
+ return value;
+}
+
+
void JSObject::SetNormalizedProperty(Handle<JSObject> object,
Handle<Name> name,
Handle<Object> value,
Index: src/objects.h
diff --git a/src/objects.h b/src/objects.h
index
a954aab9e01e5f23da5838eb2ceecd4f64f01240..930609073a0655c3770d1b4f1c5116db3937ddc2
100644
--- a/src/objects.h
+++ b/src/objects.h
@@ -2157,6 +2157,8 @@ class JSObject: public JSReceiver {
// Retrieve a value in a normalized object given a lookup result.
// Handles the special representation of JS global objects.
Object* GetNormalizedProperty(const LookupResult* result);
+ static Handle<Object> GetNormalizedProperty(Handle<JSObject> object,
+ const LookupResult* result);
// Sets the property value in a normalized object given (key, value,
details).
// Handles the special representation of JS global objects.
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
