On 2014/08/19 11:14:41, Vyacheslav Egorov (Google wrote:
https://codereview.chromium.org/467183002/diff/20001/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/467183002/diff/20001/src/objects.cc#newcode11878
src/objects.cc:11878: default:
On 2014/08/19 11:08:04, Toon Verwaest wrote:
> Any reason why you added a default case? That kinda ensures we'll
definitely
> forget to update this list when we add a new case.
Well, main reason is that enumeration has parasitic kGroupCount right now.
Right way would be to move kGroupCount out and then I could kill default:
case
here, because I do agree - it's nice to not have it, and get a warning for
uncovered cases.
If you want I can submit a follow up CL for this.
or we could turn that default case into an unreachable case for kGroupCount.
https://codereview.chromium.org/467183002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
