[ Just wading through my email backlog after vacation... ]

On 2014/08/19 11:19:06, Yang wrote:
or we could turn that default case into an unreachable case for kGroupCount.

This would have been the right way IMHO. "default" is a maintenance nightmare
most of the time.

Regarding the count within an enum: I consider this an anti-pattern and we
should remove those enum constants, there has been a discussion about this on
chromium-dev some time ago, BTW. Iterating over enum values or even doing
arithmetic with them is often a bit obscure.

https://codereview.chromium.org/467183002/

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to