Because of the potential bug you found, I thought it would be nice to have
proper unit tests for the IdleNotification.
And since we anyway want a proper class to take care of the idle time
handling,
I created one.
WDYT?
https://codereview.chromium.org/465473002/diff/60001/src/heap/heap.cc
File src/heap/heap.cc (right):
https://codereview.chromium.org/465473002/diff/60001/src/heap/heap.cc#newcode4274
src/heap/heap.cc:4274: return
static_cast<intptr_t>(marking_speed_in_bytes_per_millisecond *
On 2014/08/18 12:32:13, ulan wrote:
Potential integer overflow here, maybe use marking_speed_in_kilobytes?
Good catch.
https://codereview.chromium.org/465473002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
