LGTM, we can give this a shot.
Considering that MSan is only run with simulators, this approach shouldn't
introduce false positives due to missing unpoisoning. Have you run it
locally to
see if it reports anything?
The other caveat I mentioned on the bug is still valid, though: fast inline
allocation from generated code isn't covered by this. But some coverage is
better than no coverage, so this limitation is not a blocker.
https://codereview.chromium.org/480763003/diff/1/src/heap/heap-inl.h
File src/heap/heap-inl.h (left):
https://codereview.chromium.org/480763003/diff/1/src/heap/heap-inl.h#oldcode19
src/heap/heap-inl.h:19:
accidental edit?
https://codereview.chromium.org/480763003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
