On 2014/08/21 08:13:46, Jakob wrote:
LGTM, we can give this a shot.
Considering that MSan is only run with simulators, this approach shouldn't
introduce false positives due to missing unpoisoning. Have you run it
locally
to
see if it reports anything?
I've only verified that the reproducer in issue 403409 causes an MSan report
after this change. I've not done much to check that no false positives have
been
introduced.
By the way, I think the annotations in msan.h under !defined(USE_SIMULATOR)
can
be removed, as we don't have any plans to support that mode of usage. I'll
wait
for an OK from eugenis@ and then nuke them.
The other caveat I mentioned on the bug is still valid, though: fast
inline
allocation from generated code isn't covered by this. But some coverage is
better than no coverage, so this limitation is not a blocker.
https://codereview.chromium.org/480763003/diff/1/src/heap/heap-inl.h
File src/heap/heap-inl.h (left):
https://codereview.chromium.org/480763003/diff/1/src/heap/heap-inl.h#oldcode19
src/heap/heap-inl.h:19:
accidental edit?
Fixed, thanks.
https://codereview.chromium.org/480763003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
