Thanks for comments. PTAL.
https://codereview.chromium.org/492763002/diff/40001/src/heap/gc-idle-time-handler.cc
File src/heap/gc-idle-time-handler.cc (right):
https://codereview.chromium.org/492763002/diff/40001/src/heap/gc-idle-time-handler.cc#newcode61
src/heap/gc-idle-time-handler.cc:61: intptr_t speed =
gc_tracer->MaxMarkSweepSpeedInBytesPerMillisecond();
On 2014/08/20 18:24:11, Hannes Payer wrote:
Why are we taking the maximum?
Good catch, it should be either minimum or average. Made average to be
consistent with other estimates.
https://codereview.chromium.org/492763002/diff/40001/src/heap/gc-idle-time-handler.h
File src/heap/gc-idle-time-handler.h (right):
https://codereview.chromium.org/492763002/diff/40001/src/heap/gc-idle-time-handler.h#newcode21
src/heap/gc-idle-time-handler.h:21: struct GCIdleTimeAction {
On 2014/08/20 18:24:11, Hannes Payer wrote:
According to the style guide, this should be a class.
Done.
https://codereview.chromium.org/492763002/diff/40001/src/heap/gc-idle-time-handler.h#newcode74
src/heap/gc-idle-time-handler.h:74: void NotifyIdleFullGC() {
On 2014/08/20 18:24:11, Hannes Payer wrote:
In the gc tracer we refer to the event as mark compact event. Let's
make sure we
use the same terminology here.
NotifyIdleFullGC -> NotifyIdleMarkCompact
Done.
https://codereview.chromium.org/492763002/diff/40001/src/heap/gc-idle-time-handler.h#newcode100
src/heap/gc-idle-time-handler.h:100: static const int
kMaxMarkSweepsInIdleRound = 7;
On 2014/08/20 18:24:11, Hannes Payer wrote:
kMaxMarkSweepsInIdleRound -> kMaxMarkCompactsInIdleRound
Done.
https://codereview.chromium.org/492763002/diff/40001/src/heap/heap.cc
File src/heap/heap.cc (right):
https://codereview.chromium.org/492763002/diff/40001/src/heap/heap.cc#newcode4300
src/heap/heap.cc:4300: if (incremental_marking()->IsStopped()) {
On 2014/08/20 18:24:11, Hannes Payer wrote:
I think this check should be in the Compute function.
Acknowledged.
https://codereview.chromium.org/492763002/diff/40001/src/heap/heap.cc#newcode4325
src/heap/heap.cc:4325: mark_compact_collector()->sweeping_in_progress())
{
On 2014/08/20 18:24:11, Hannes Payer wrote:
Should we do a SWEEP action., which is selected when the "hint" is
large enough
and sweeping is in progress. WDYT?
Agreed, but let's do this in a separate CL to reduce risk of reverting
CL.
https://codereview.chromium.org/492763002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
