https://codereview.chromium.org/492763002/diff/100001/src/heap/gc-idle-time-handler.cc
File src/heap/gc-idle-time-handler.cc (right):
https://codereview.chromium.org/492763002/diff/100001/src/heap/gc-idle-time-handler.cc#newcode38
src/heap/gc-idle-time-handler.cc:38: intptr_t size_of_objects, intptr_t
mark_sweep_speed_in_bytes_per_ms) {
Can we make the parameters size_t, c.f. EstimateMarkingStepSize.
https://codereview.chromium.org/492763002/diff/100001/src/heap/gc-idle-time-handler.cc#newcode40
src/heap/gc-idle-time-handler.cc:40: const int kMaxTimeInMs = 1000000;
I think these constant should be in GCIdleTImeHandler, otherwise it will
be hard to test this function. Btw. can we have unit tests, similar to
the EstimateMarkingStepSize tests.
https://codereview.chromium.org/492763002/diff/100001/src/heap/gc-tracer.cc
File src/heap/gc-tracer.cc (right):
https://codereview.chromium.org/492763002/diff/100001/src/heap/gc-tracer.cc#newcode423
src/heap/gc-tracer.cc:423: intptr_t
GCTracer::MarkCompactSpeedInBytesPerMillisecond() const {
The GCTracer functions should also operate on size_t. We should fix that
in a separate cl.
https://codereview.chromium.org/492763002/diff/100001/src/heap/heap.cc
File src/heap/heap.cc (right):
https://codereview.chromium.org/492763002/diff/100001/src/heap/heap.cc#newcode4323
src/heap/heap.cc:4323: const int kMinHintForFullGC = 100;
Please add a todo here for sweeping events.
https://codereview.chromium.org/492763002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
