https://codereview.chromium.org/475423003/diff/160001/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/475423003/diff/160001/src/objects.cc#newcode9302
src/objects.cc:9302: Handle<JSFunction>
JSFunction::Copy(Handle<JSFunction> function) {
This method doesn't exactly copy a function anymore. It just creates a
new closure with the same bindings, bound values, and prototype. Please
rename to indicate this.
https://codereview.chromium.org/475423003/diff/160001/src/objects.cc#newcode9318
src/objects.cc:9318: JSObject::SetPrototype(clone, original_prototype,
false).Assert();
JSObject::SetPrototype isn't exactly a no-op right now; it does a whole
lot of stuff. Either manually check here, or there, whether it's the
same object.
https://codereview.chromium.org/475423003/diff/160001/src/runtime.cc
File src/runtime.cc (right):
https://codereview.chromium.org/475423003/diff/160001/src/runtime.cc#newcode2064
src/runtime.cc:2064: DONT_ENUM).Assert();
Are you using "git cl format"? This seems weirdly formatted for our
auto-format...
https://codereview.chromium.org/475423003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
