https://codereview.chromium.org/484273003/diff/1/test/cctest/compiler/test-run-jscalls.cc
File test/cctest/compiler/test-run-jscalls.cc (right):
https://codereview.chromium.org/484273003/diff/1/test/cctest/compiler/test-run-jscalls.cc#newcode252
test/cctest/compiler/test-run-jscalls.cc:252:
FLAG_context_specialization = false;
On 2014/08/21 08:12:06, titzer wrote:
On 2014/08/20 07:53:22, sigurds wrote:
> I left this flag in here.
> I could add it as a parameter to Pipeline, and expose the parameter
through
> function tester.
Please add a TODO.
Implemented it.
https://codereview.chromium.org/484273003/diff/1/test/cctest/compiler/test-run-jscalls.cc#newcode263
test/cctest/compiler/test-run-jscalls.cc:263: v8::Local<v8::Context> env
= v8::Context::New(isolate);
On 2014/08/21 08:12:06, titzer wrote:
Maybe you can factor this out into function-tester as
RunInSeparateContext or
something?
Done.
https://codereview.chromium.org/484273003/diff/20001/test/cctest/compiler/test-run-jscalls.cc
File test/cctest/compiler/test-run-jscalls.cc (right):
https://codereview.chromium.org/484273003/diff/20001/test/cctest/compiler/test-run-jscalls.cc#newcode262
test/cctest/compiler/test-run-jscalls.cc:262:
[&T](v8::Handle<v8::Context> context, Handle<JSFunction> function) {
Look at this beautiful lambda :)
I'll replace it with a static function if desired.
https://codereview.chromium.org/484273003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
