https://codereview.chromium.org/484273003/diff/40001/src/compiler/pipeline.h
File src/compiler/pipeline.h (right):

https://codereview.chromium.org/484273003/diff/40001/src/compiler/pipeline.h#newcode29
src/compiler/pipeline.h:29: : info_(info),
context_specialization_(context_specialization) {}
Let's make this a mutable field and not a constructor parameter. I
foresee many such options and making them all constructor parameters
will become cumbersome.

https://codereview.chromium.org/484273003/diff/40001/test/cctest/compiler/test-run-jscalls.cc
File test/cctest/compiler/test-run-jscalls.cc (right):

https://codereview.chromium.org/484273003/diff/40001/test/cctest/compiler/test-run-jscalls.cc#newcode249
test/cctest/compiler/test-run-jscalls.cc:249: #if V8_TURBOFAN_TARGET
Why are these guarded with TURBOFAN_TARGET and the others are not?

https://codereview.chromium.org/484273003/

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to