https://codereview.chromium.org/477263002/diff/80001/src/parser.h
File src/parser.h (right):
https://codereview.chromium.org/477263002/diff/80001/src/parser.h#newcode577
src/parser.h:577: FunctionLiteral::IsGeneratorFlag is_generator,
Are these flag mutually exclusive; Afaik an arrow function cannot be a
generator, so, it would make sense to have a three-value flag (normal,
arrow, generator) instead of 2 bools.
How does IsConcise relate to them? Looks like it cannot be an arrow
function and it cannot be a generator either?
So would it make sense to have a 4-value flag (normal, arrow, generator,
concise) here?
https://codereview.chromium.org/477263002/diff/80001/test/cctest/test-parsing.cc
File test/cctest/test-parsing.cc (right):
https://codereview.chromium.org/477263002/diff/80001/test/cctest/test-parsing.cc#newcode3394
test/cctest/test-parsing.cc:3394: const char* context_data[][2] =
{{"({", "});"},
Is there a reason why you do
({ stuff });
and not just
{ stuff }
?
https://codereview.chromium.org/477263002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.