https://codereview.chromium.org/477263002/diff/160001/src/ast.h
File src/ast.h (right):
https://codereview.chromium.org/477263002/diff/160001/src/ast.h#newcode2493
src/ast.h:2493: class IsArrow : public BitField<bool, 6, 1> {};
On 2014/09/02 14:42:48, arv wrote:
On 2014/08/25 09:39:29, rossberg wrote:
> Please don't define overlapping bitfields. In particular, these ones
silently
> break when somebody changes the values in the definition of
FunctionKind.
Yes, it does have a tight coupling but it leads to more concise and
more
efficient code.
What would be your suggestion? To remove IsArrow, IsGenerator and
IsConciseMethod and then do another masking as needed?
Yes. Just add some global helpers IsArrowKind, IsGeneratorKind and so on
if you want to avoid bit fiddling everywhere.
https://codereview.chromium.org/477263002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
