On 2014/08/22 10:46:59, baixo wrote:
On 2014/08/22 10:17:20, rmcilroy wrote:
> +vogelheim: Could you take a look please? The external snapshot code
was
> crashing for Andre before he added this fix.
>
> https://codereview.chromium.org/496253003/diff/1/tools/js2c.py
> File tools/js2c.py (right):
>
>
https://codereview.chromium.org/496253003/diff/1/tools/js2c.py#newcode513
> tools/js2c.py:513: value += '\0'
> Add a comment stating why this is necessary.
Comment added.
Looks good to me, I'll leave vogelheim to approve.
https://codereview.chromium.org/496253003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
