Changed to strncmp

https://codereview.chromium.org/496253003/diff/20001/tools/js2c.py
File tools/js2c.py (right):

https://codereview.chromium.org/496253003/diff/20001/tools/js2c.py#newcode514
tools/js2c.py:514: value += '\0'
You're right. Just changed the strcmp side.

On 2014/08/26 12:43:12, vogelheim wrote:
I really don't get this. Could you elaborate on what the problem is?

The reason why the string is length-prefixed is so that we don't have
to rely on
string termination. If someone expects to strcmp the result of this,
that would
indicate a problem at that end...

https://codereview.chromium.org/496253003/

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to