Ok...and I thought I signed the CLA twice ( https://groups.google.com/forum/#!topic/v8-users/FcaO80-pY6s). Sorry for the late response...I've been busy getting ready to start college next week (lot of paperwork, etc). As soon as I get a chance, I will give those a more in-depth look.
On Tue, Aug 19, 2014 at 8:29 AM, <[email protected]> wrote: > Please add test cases for cases specific to this impelementation, like for > n = > 2^m-1, etc. > > Also, please sign the CLA: > https://developers.google.com/open-source/cla/individual?csw=1 > > > https://codereview.chromium.org/401783003/diff/80001/src/harmony-string.js > File src/harmony-string.js (right): > > https://codereview.chromium.org/401783003/diff/80001/src/ > harmony-string.js#newcode31 > src/harmony-string.js:31: if (n % 2) res += s; > two-character indent please. > > https://codereview.chromium.org/401783003/diff/80001/src/ > harmony-string.js#newcode36 > src/harmony-string.js:36: // unroll last iteration, no need to double > the initial string again at the > Capitalize "unroll". > > https://codereview.chromium.org/401783003/diff/80001/src/ > harmony-string.js#newcode43 > src/harmony-string.js:43: return %StringBuilderConcat(array, 1, ""); > Use %FlattenString > > https://codereview.chromium.org/401783003/ > -- Isiah Meadows -- -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
