Looks good as far as I can tell.
Toon need to look at this too since this is still outside my comfort zone.
https://codereview.chromium.org/527963002/diff/1/src/compiler.cc
File src/compiler.cc (right):
https://codereview.chromium.org/527963002/diff/1/src/compiler.cc#newcode409
src/compiler.cc:409: // TODO(turbofan): Make super work and remove this
bailour.
typo
https://codereview.chromium.org/527963002/diff/1/test/mjsunit/harmony/super.js
File test/mjsunit/harmony/super.js (right):
https://codereview.chromium.org/527963002/diff/1/test/mjsunit/harmony/super.js#newcode71
test/mjsunit/harmony/super.js:71: return this._x;
maybe assert that this === derived
var derived = new Derived();
assertEquals('derived', derived.testGetter());
https://codereview.chromium.org/527963002/diff/1/test/mjsunit/harmony/super.js#newcode85
test/mjsunit/harmony/super.js:85: }.toMethod(Derived.prototype);
wrong indentation
https://codereview.chromium.org/527963002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
