PTAL. Added access checks & addressed other feedback.
Last check before platform ports.
https://codereview.chromium.org/527963002/diff/20001/src/ia32/full-codegen-ia32.cc
File src/ia32/full-codegen-ia32.cc (right):
https://codereview.chromium.org/527963002/diff/20001/src/ia32/full-codegen-ia32.cc#newcode1298
src/ia32/full-codegen-ia32.cc:1298: __ mov(eax, FieldOperand(eax,
Map::kPrototypeOffset));
On 2014/09/15 13:18:25, Dmitry Lomov (chromium) wrote:
As discussed offline, this skips the access check on prototype load.
Oh well.
LoadFromSuper should take (home_object, this_value, name) as args.
Done.
https://codereview.chromium.org/527963002/diff/20001/src/runtime.cc
File src/runtime.cc (right):
https://codereview.chromium.org/527963002/diff/20001/src/runtime.cc#newcode2084
src/runtime.cc:2084: if (it.IsFound()) {
On 2014/09/15 13:16:43, Toon Verwaest wrote:
You don't need this it.IsFound() either... GetProperty will return
undefined for
you.
Done.
https://codereview.chromium.org/527963002/diff/20001/test/mjsunit/harmony/super.js
File test/mjsunit/harmony/super.js (right):
https://codereview.chromium.org/527963002/diff/20001/test/mjsunit/harmony/super.js#newcode72
test/mjsunit/harmony/super.js:72: assertTrue(this === derived);
On 2014/09/15 13:16:43, Toon Verwaest wrote:
assertSame
Done.
https://codereview.chromium.org/527963002/diff/20001/test/mjsunit/harmony/super.js#newcode87
test/mjsunit/harmony/super.js:87: }.toMethod(Derived.prototype);
On 2014/09/15 15:22:57, arv wrote:
Still wrong indentation. function bodies indent 2 spaces, even when
used as part
of another expression/statement.
Derived.prototype.testGetter = function() {
return super.x;
}.toMethod(Derived.prototype);
Done.
https://codereview.chromium.org/527963002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
