More comments. This seems to return 'null' when retrieving the empty string, not just on EOF. Is that intentional?
http://codereview.chromium.org/173262/diff/6001/7001 File src/d8.cc (right): http://codereview.chromium.org/173262/diff/6001/7001#newcode185 Line 185: i::SmartPointer<char> line(new char[size]); Smart pointers need their contents to be allocated using NewArray. Also, wouldn't it be easier to just use i::ReadLine from utils.h? http://codereview.chromium.org/173262 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
