Sorry, I read that wrong. No, it should only return Null on EOF. On 2009/09/07 12:21:15, abdulla wrote: > Yup, that is intentional. I'm returning Null to mimic the behaviour of > TraceMonkey:
http://hg.mozilla.org/tracemonkey/file/45772700955a/js/src/shell/js.cpp#l998 > http://codereview.chromium.org/173262/diff/6001/7001 > File src/d8.cc (right): > http://codereview.chromium.org/173262/diff/6001/7001#newcode185 > Line 185: i::SmartPointer<char> line(new char[size]); > On 2009/09/07 09:26:35, Christian Plesner Hansen wrote: > > Smart pointers need their contents to be allocated using NewArray. Also, > > wouldn't it be easier to just use i::ReadLine from utils.h? > Done. http://codereview.chromium.org/173262 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
