https://codereview.chromium.org/551803004/diff/1/src/objects-inl.h
File src/objects-inl.h (right):
https://codereview.chromium.org/551803004/diff/1/src/objects-inl.h#newcode3298
src/objects-inl.h:3298: WRITE_INTPTR_FIELD(this, kHashFieldSlot, value);
Hmmm, this is a bit brittle for 2 reasons: Writing an unsigned value via
a pointer to a signed value can lead to undefined behavior. Furthermore,
intptr_t could actually be *larger* than a pointer (it just needs to be
big enough to allow a conversion from/to a pointer, the other way it's
not required to be a no-op), but probably no implementation does it...
https://codereview.chromium.org/551803004/diff/1/src/objects.h
File src/objects.h (right):
https://codereview.chromium.org/551803004/diff/1/src/objects.h#newcode3171
src/objects.h:3171: kExtendedInt64CountOffset + kInt32Size;
I think that this is wrong: We access this via
READ_INT_FIELD/WRITE_INT_FIELD, and they use *int*, not *int32_t*. Same
for the rest. kPointerSize was wrong, too, BTW...
@Ross: What do you think? Somehow the accessors have to match these
constants.
https://codereview.chromium.org/551803004/diff/1/src/objects.h#newcode7293
src/objects.h:7293: #elif V8_TARGET_BIG_ENDIAN
This is very fragile: At least we have to cross-reference these
constants with the (PSEUDO_)SMI_ACCESOR stuff in objects-inl.h, in both
directions.
(What we *really* need is some kind of DSL describing our object
layouts, this is getting really ugly...)
https://codereview.chromium.org/551803004/diff/1/test/cctest/test-strings.cc
File test/cctest/test-strings.cc (right):
https://codereview.chromium.org/551803004/diff/1/test/cctest/test-strings.cc#newcode1411
test/cctest/test-strings.cc:1411: memset(dummy.start(), 0x0,
dummy.length() * sizeof(TYPE)); \
Why exactly do we need this?
https://codereview.chromium.org/551803004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
