I've updated the patch to reflect the comments.
https://codereview.chromium.org/551803004/diff/1/src/objects-inl.h
File src/objects-inl.h (right):
https://codereview.chromium.org/551803004/diff/1/src/objects-inl.h#newcode3298
src/objects-inl.h:3298: WRITE_INTPTR_FIELD(this, kHashFieldSlot, value);
Changed to still use kHashFieldSlot to reference the storage space used
by the hash field, but using UINT32 writes.
https://codereview.chromium.org/551803004/diff/1/src/objects.h
File src/objects.h (right):
https://codereview.chromium.org/551803004/diff/1/src/objects.h#newcode3171
src/objects.h:3171: kExtendedInt64CountOffset + kInt32Size;
On 2014/09/18 10:54:44, rmcilroy wrote:
On 2014/09/16 10:48:40, Sven Panne wrote:
> I think that this is wrong: We access this via
READ_INT_FIELD/WRITE_INT_FIELD,
> and they use *int*, not *int32_t*. Same for the rest. kPointerSize
was wrong,
> too, BTW...
>
> @Ross: What do you think? Somehow the accessors have to match these
constants.
Yeah I agree - Andrew - could you change the accessors to use
READ/WRITE_INT32_FIELD as well please.
Done.
https://codereview.chromium.org/551803004/diff/1/src/objects.h#newcode7293
src/objects.h:7293: #elif V8_TARGET_BIG_ENDIAN
It's not clear what you're suggesting should be done here.
https://codereview.chromium.org/551803004/diff/1/test/cctest/test-strings.cc
File test/cctest/test-strings.cc (right):
https://codereview.chromium.org/551803004/diff/1/test/cctest/test-strings.cc#newcode1411
test/cctest/test-strings.cc:1411: memset(dummy.start(), 0x0,
dummy.length() * sizeof(TYPE)); \
On 2014/09/16 10:48:40, Sven Panne wrote:
Why exactly do we need this?
When we test on AIX there are tests that fail if this memset is not
present. I'll drop it from this patch for now.
https://codereview.chromium.org/551803004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
