Reviewers: Weiliang, mvstanton,
Message:
hello. Mvstanton.
PTAL.
thanks.
Description:
Fix the IsTheHole bug.
For Double constant of non nan, object_ may be uninitialized.
(This patch comes from [email protected] )
BUG=
Please review this at https://codereview.chromium.org/565183004/
SVN Base: https://chromium.googlesource.com/external/v8.git@bleeding_edge
Affected files (+2, -1 lines):
M src/hydrogen-instructions.h
Index: src/hydrogen-instructions.h
diff --git a/src/hydrogen-instructions.h b/src/hydrogen-instructions.h
index
bcf5492b72390317973a6a2124ca75d3f1912751..ab571470a934c1992eb9659d82e5a2feb77db9cc
100644
--- a/src/hydrogen-instructions.h
+++ b/src/hydrogen-instructions.h
@@ -3593,7 +3593,8 @@ class HConstant FINAL : public
HTemplateInstruction<0> {
if (HasDoubleValue() &&
FixedDoubleArray::is_the_hole_nan(double_value_)) {
return true;
}
- return object_.IsKnownGlobal(isolate()->heap()->the_hole_value());
+ return object_.IsInitialized() &&
+ object_.IsKnownGlobal(isolate()->heap()->the_hole_value());
}
bool HasNumberValue() const { return has_double_value_; }
int32_t NumberValueAsInteger32() const {
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
