https://codereview.chromium.org/579723004/diff/1/src/compiler/simplified-operator.cc
File src/compiler/simplified-operator.cc (right):
https://codereview.chromium.org/579723004/diff/1/src/compiler/simplified-operator.cc#newcode68
src/compiler/simplified-operator.cc:68: V(BooleanToNumber,
Operator::kNoProperties, 1) \
Should be pure. And I think the Number operators should be as well.
https://codereview.chromium.org/579723004/diff/1/test/cctest/compiler/test-simplified-lowering.cc
File test/cctest/compiler/test-simplified-lowering.cc (right):
https://codereview.chromium.org/579723004/diff/1/test/cctest/compiler/test-simplified-lowering.cc#newcode825
test/cctest/compiler/test-simplified-lowering.cc:825:
TEST(LowerBooleanToNumber_tagged_int32) {
Maybe also want to test it being used as tagged, to make sure that you
don't get the boolean, but a tagged number result.
https://codereview.chromium.org/579723004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
