On 2014/09/18 at 06:11:16, mathias wrote:
On 2014/09/18 01:28:31, caitp wrote:
> https://codereview.chromium.org/579973002/diff/1/src/harmony-array.js
> File src/harmony-array.js (right):
>
>
https://codereview.chromium.org/579973002/diff/1/src/harmony-array.js#newcode129
> src/harmony-array.js:129: function ArrayContains(searchElement /*,
fromIndex
*/)
> { // length == 1
> arv@ has suggested using `%FunctionSetLength(function, length);` to get
the
> length right instead, so that we don't have tp use weirdness like
%_Arguments()
Yang overruled that in the past in favor of the currently used technique.
That was the opposite case. In this case I find it better to use
%FunctionSetLength since using %_Arguments(1) is not as clear.
Domenic, nice work! Don't forget to increment `EXPECTED_BUILTINS_COUNT` in
`tools/generate-runtime-tests.py`.
The runtime tests have been removed.
https://codereview.chromium.org/579973002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
