As this is a new unapproved feature, this needs intent-to-implement mail.
Will send
I guess this is the first time when somebody add test262 tests first and
patch
later, but I think we still want some tests in our tree (under
test/mjsunit/harmony)
I would really like us to break out of the pattern of creating our own tests
separate from the vendor-independent ones. I am hoping we can pioneer that
process here. I am also going to be investigating improvements to test262 to
make writing tests there as easy as mjsunit ones (e.g. adding assert
helpers).
Perhaps it would help to have an "unsubmitted" subfolder of the test262
tests
that we can check in so as to decouple ourselves from the merging process of
test262? That is what Mozilla will likely be doing, it seems:
https://groups.google.com/forum/#!topic/mozilla.dev.tech.js-engine.internals/VmjEa2ATcNo
Can you remind me what stage this proposal is currently in?
Stage 1. Advancement to stage 2 requires experimental implementations,
which is
the point of this patch (as well as the Mozilla one) :)
I agree with Dmitry that there needs to be an intent mail and appropriate
discussion, especially since this sets a precedent for our future
handling of
ES7 features. I also think that the implementation needs to go under a
different
flag than any ES6 functionality, since we need to be able to activate and
ship
one without the other.
Happy to have that discussion. That is pretty much the point of
Array.prototype.contains after all.
(For the same reason, it does not make sense to push tests for it into
test262
at this time. At least not until test262 has a way to distinguish language
versions.)
test262 is generally on-board with the idea of decoupling what version of
the
Ecma standard a feature is in from its presence in the test suite, so it
will
likely end up there since it has approval.
https://codereview.chromium.org/579973002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
