ptal
https://codereview.chromium.org/596533002/diff/1/include/v8.h
File include/v8.h (right):
https://codereview.chromium.org/596533002/diff/1/include/v8.h#newcode4568
include/v8.h:4568: int GetStackSample(const RegisterState& state, void**
frames,
On 2014/09/23 05:47:48, Benedikt Meurer wrote:
Nit: int -> size_t
Done.
I just saw v8 tends to use int whenever possible.
https://codereview.chromium.org/596533002/diff/1/include/v8.h#newcode4569
include/v8.h:4569: int frames_limit);
On 2014/09/23 05:47:48, Benedikt Meurer wrote:
Nit: int -> size_t
Done.
https://codereview.chromium.org/596533002/diff/1/src/sampler.cc
File src/sampler.cc (right):
https://codereview.chromium.org/596533002/diff/1/src/sampler.cc#newcode619
src/sampler.cc:619: int TickSample::GetStackSample(Isolate* isolate,
const v8::RegisterState& regs,
On 2014/09/23 05:47:48, Benedikt Meurer wrote:
Nit: int -> size_t
Done.
https://codereview.chromium.org/596533002/diff/1/src/sampler.cc#newcode620
src/sampler.cc:620: void** frames, int frames_limit) {
On 2014/09/23 05:47:48, Benedikt Meurer wrote:
Nit: int -> size_t
Done.
https://codereview.chromium.org/596533002/diff/1/src/sampler.cc#newcode630
src/sampler.cc:630: int i = 0;
On 2014/09/23 05:47:48, Benedikt Meurer wrote:
Nit: int -> size_t
Done.
https://codereview.chromium.org/596533002/diff/1/test/cctest/cctest.status
File test/cctest/cctest.status (right):
https://codereview.chromium.org/596533002/diff/1/test/cctest/cctest.status#newcode355
test/cctest/cctest.status:355: 'test-sampler-api/*': [SKIP],
On 2014/09/23 05:39:18, gholap wrote:
https://codereview.chromium.org/588623002/ uses POSIX signals for the
tests.
Still arm builds were failing. Passes MacOS (MacOS means osx, right?)
though.
Let's address arm tests in a separate patch.
https://codereview.chromium.org/596533002/diff/1/test/cctest/test-sampler-api.cc
File test/cctest/test-sampler-api.cc (right):
https://codereview.chromium.org/596533002/diff/1/test/cctest/test-sampler-api.cc#newcode249
test/cctest/test-sampler-api.cc:249: return;
On 2014/09/23 05:44:35, info1 wrote:
There is a getcontext() on OS X but you have to build with
_XOPEN_SOURCE
defined, something V8 doesn't do, I think.
Yep, I'm not sure v8 wants to use _XOPEN_SOURCE just for this test. So I
think we should emulate getcontext with signals.
https://codereview.chromium.org/596533002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
