https://codereview.chromium.org/596533002/diff/60001/src/sampler.cc
File src/sampler.cc (right):
https://codereview.chromium.org/596533002/diff/60001/src/sampler.cc#newcode623
src/sampler.cc:623: Address js_entry_sp = isolate->js_entry_sp();
I expected that we wouldn't collect call stack if current vm state is
GC. I think we should match TickSample::Init in this case and return
current vm state to indicate that GC is in progress without crawling the
stack. Or is it always safe to collect current stack frames and be
prepare that some of the PCs may be invalid?
https://codereview.chromium.org/596533002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
