I fixed the Name register issue in this patch set.
Yes, you are right, Name register must contain correct value in case of
deopt. I
wasn't able to write the test that triggers deopt because mismatching
representation is handled in StoreTransition handler before the call to
ExtendStorageStub, but I tested that it works manually by temporarily
inserting
a check that fails into the stub.
https://codereview.chromium.org/587203002/diff/1/src/hydrogen.cc
File src/hydrogen.cc (right):
https://codereview.chromium.org/587203002/diff/1/src/hydrogen.cc#newcode2858
src/hydrogen.cc:2858: store->SetFlag(HValue::kAllowUndefinedAsNaN);
On 2014/09/22 08:55:29, Toon Verwaest wrote:
I don't think this flag has any meaning for FAST_ELEMENTS.
Done.
https://codereview.chromium.org/587203002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
