LGTM with comments.
https://codereview.chromium.org/587203002/diff/20001/src/code-stubs-hydrogen.cc
File src/code-stubs-hydrogen.cc (right):
https://codereview.chromium.org/587203002/diff/20001/src/code-stubs-hydrogen.cc#newcode678
src/code-stubs-hydrogen.cc:678:
BuildAllocateElementsAndInitializeElementsHeader(kind, new_capacity);
The name of that function is now somewhat misleading. We are allocating
properties, not elements. I don't have any idea how to rename it off the
top of my head though :/
https://codereview.chromium.org/587203002/diff/20001/src/code-stubs-hydrogen.cc#newcode686
src/code-stubs-hydrogen.cc:686:
BuildStoreNamedField(GetParameter(ExtendStorageDescriptor::kReceiverIndex),
Isn't this just 'object'?
https://codereview.chromium.org/587203002/diff/20001/src/code-stubs.h
File src/code-stubs.h (right):
https://codereview.chromium.org/587203002/diff/20001/src/code-stubs.h#newcode86
src/code-stubs.h:86: V(ExtendStorage) \
Put this before LoadConstant please. We try to maintain an alphabetical
order.
https://codereview.chromium.org/587203002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
