lgtm with comments
https://codereview.chromium.org/596703004/diff/10031/src/arm64/assembler-arm64.h
File src/arm64/assembler-arm64.h (right):
https://codereview.chromium.org/596703004/diff/10031/src/arm64/assembler-arm64.h#newcode280
src/arm64/assembler-arm64.h:280: static int
NumAllocatableRegistersForTurbofan() {
Can we name this something more general? Such as
NumAllocatableFloat32Registers() or something?
https://codereview.chromium.org/596703004/diff/10031/src/compiler/arm/code-generator-arm.cc
File src/compiler/arm/code-generator-arm.cc (right):
https://codereview.chromium.org/596703004/diff/10031/src/compiler/arm/code-generator-arm.cc#newcode25
src/compiler/arm/code-generator-arm.cc:25: class ArmOperandConverter
FINAL : public InstructionOperandConverter {
Is the final really necessary? This class is local to this file.
https://codereview.chromium.org/596703004/diff/10031/src/compiler/ia32/instruction-codes-ia32.h
File src/compiler/ia32/instruction-codes-ia32.h (right):
https://codereview.chromium.org/596703004/diff/10031/src/compiler/ia32/instruction-codes-ia32.h#newcode37
src/compiler/ia32/instruction-codes-ia32.h:37: V(Cvtss2sd)
\
SSE prefix
https://codereview.chromium.org/596703004/diff/10031/src/compiler/x64/instruction-codes-x64.h
File src/compiler/x64/instruction-codes-x64.h (right):
https://codereview.chromium.org/596703004/diff/10031/src/compiler/x64/instruction-codes-x64.h#newcode53
src/compiler/x64/instruction-codes-x64.h:53: V(Cvtss2sd)
\
SSE prefix
https://codereview.chromium.org/596703004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
