https://codereview.chromium.org/593563005/diff/290001/src/basic-block-profiler.h
File src/basic-block-profiler.h (right):
https://codereview.chromium.org/593563005/diff/290001/src/basic-block-profiler.h#newcode26
src/basic-block-profiler.h:26: int* block_ids() { return &block_ids_[0];
}
set_block_id(int block, int id) and hide it?
https://codereview.chromium.org/593563005/diff/290001/src/compiler/basic-block-instrumentor.cc
File src/compiler/basic-block-instrumentor.cc (right):
https://codereview.chromium.org/593563005/diff/290001/src/compiler/basic-block-instrumentor.cc#newcode16
src/compiler/basic-block-instrumentor.cc:16: static NodeVector::iterator
FindInsertionPoint(NodeVector* nodes) {
Comment me.
https://codereview.chromium.org/593563005/diff/290001/src/compiler/basic-block-instrumentor.cc#newcode72
src/compiler/basic-block-instrumentor.cc:72: BasicBlock* block = (*it);
Pull me out into a separate function
https://codereview.chromium.org/593563005/diff/290001/src/compiler/basic-block-instrumentor.cc#newcode82
src/compiler/basic-block-instrumentor.cc:82: Node* load =
graph->NewNode(machine.Load(kMachUint32), base, index);
I'd just smash in the direct pointer into the middle here, so we can
have that as the base and always index 0.
https://codereview.chromium.org/593563005/diff/290001/src/compiler/pipeline.cc
File src/compiler/pipeline.cc (right):
https://codereview.chromium.org/593563005/diff/290001/src/compiler/pipeline.cc#newcode419
src/compiler/pipeline.cc:419: code->Disassemble(NULL, os);
Why do we need to eagerly disassemble the code?
https://codereview.chromium.org/593563005/diff/290001/src/flag-definitions.h
File src/flag-definitions.h (right):
https://codereview.chromium.org/593563005/diff/290001/src/flag-definitions.h#newcode353
src/flag-definitions.h:353: DEFINE_STRING(turbo_profiling_filter, "*",
"profiling filter in TurboFan")
Let's just profile it all...
https://codereview.chromium.org/593563005/diff/290001/tools/gyp/v8.gyp
File tools/gyp/v8.gyp (right):
https://codereview.chromium.org/593563005/diff/290001/tools/gyp/v8.gyp#newcode355
tools/gyp/v8.gyp:355: '../../src/basic-block-profiler.h',
Don't forget build.gn.
https://codereview.chromium.org/593563005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
