lgtm with comment
https://codereview.chromium.org/593563005/diff/290001/src/flag-definitions.h
File src/flag-definitions.h (right):
https://codereview.chromium.org/593563005/diff/290001/src/flag-definitions.h#newcode353
src/flag-definitions.h:353: DEFINE_STRING(turbo_profiling_filter, "*",
"profiling filter in TurboFan")
On 2014/09/25 08:15:15, dcarney wrote:
On 2014/09/24 14:59:31, titzer wrote:
> Let's just profile it all...
okay, but I've found it useful to limit the output
Ok, you can leave it in.
https://codereview.chromium.org/593563005/diff/330001/src/compiler/basic-block-instrumentor.cc
File src/compiler/basic-block-instrumentor.cc (right):
https://codereview.chromium.org/593563005/diff/330001/src/compiler/basic-block-instrumentor.cc#newcode87
src/compiler/basic-block-instrumentor.cc:87: Node* to_insert[kArraySize]
= {zero, one, base, load, inc, store};
I don't think you want to insert zero and one in every block; every node
should have just one place in the schedule.
https://codereview.chromium.org/593563005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
