Hi Ben - Thanks for getting to the review so quickly, for your kind words,
and
for the good feedback you gave. I've factored out the changes to the base
mips
port files as you requested, and those are already landed. I've rebased this
patch, and have implemented the sqrt and float32 stuff that landed today.
I've
run into bugs on my float32 implementation, and I'll have to resume with
that in
the morning.
You had several good suggestions that I'll implement immediately, and some
questions about overflow detection and branch handling that get a little
deeper.
I'd agree that these need improvement, but there are some constraints and
issues. I'll give you my feedback tomorrow, and then we can decide the
proper
direction to move forward on these.
thanks!
https://codereview.chromium.org/601723002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
