Looking good. Please also add tests that actually run the generated code (as
discussed offline).
https://codereview.chromium.org/620553008/diff/1/src/compiler/simplified-lowering.cc
File src/compiler/simplified-lowering.cc (right):
https://codereview.chromium.org/620553008/diff/1/src/compiler/simplified-lowering.cc#newcode355
src/compiler/simplified-lowering.cc:355: bool CanBeInt32Binop(Node*
node, MachineTypeUnion use) {
I find the "CanBe" prefix confusing in this setting, I assume it is
meant to indicate "can be lowered to"? Could we instead just call it
"IsInt32Binop"?
https://codereview.chromium.org/620553008/diff/1/src/compiler/simplified-lowering.cc#newcode359
src/compiler/simplified-lowering.cc:359: bool CanBeUint32Binop(Node*
node, MachineTypeUnion use) {
Likewise.
https://codereview.chromium.org/620553008/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
